docs: update example redis tags from 3.0.x to 7.4.x #5595
Conversation
Signed-off-by: David Karlsson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5595 +/- ##
==========================================
- Coverage 59.63% 59.63% -0.01%
==========================================
Files 346 346
Lines 29214 29208 -6
==========================================
- Hits 17421 17417 -4
+ Misses 10824 10822 -2
Partials 969 969 |
| @@ -93,8 +93,8 @@ The following filter matches tasks with the `usage` label regardless of its valu | |||
| $ docker node ps -f "label=usage" | |||
|
|
|||
| NAME IMAGE NODE DESIRED STATE CURRENT STATE | |||
| redis.6.b465edgho06e318egmgjbqo4o redis:3.0.6 swarm-manager1 Running Running 10 minutes | |||
| redis.7.bg8c07zzg87di2mufeq51a2qp redis:3.0.6 swarm-manager1 Running Running 9 minutes | |||
| redis.6.b465edgho06e318egmgjbqo4o redis:7.4.1 swarm-manager1 Running Running 10 minutes | |||
There was a problem hiding this comment.
Perhaps we should use 7.4 (or even 7), to prevent these examples getting outdated. Generally, my recommendation would be to pin to either major, or major.minor, as patch releases should always be safe to update (and may contain security updates).
There was a problem hiding this comment.
I agree in principle, but I wanted to keep the patch version (and character count of this string) to avoid having to worry about whitespace alignment. If we change to 7 or 7.4, we need to fix the whitespace padding on the header row etc.
At some point I would like to replace the redis examples with something open source instead.
There was a problem hiding this comment.
Ah, right, that's fair.
I also left this comment before considering that one of the examples needs to show "updating", and I guess for that it makes more sense to update to a newer patch release (compared to "minor" release).
| 50qe8lfnxaxk redis.1 redis:7.4.1 manager1 Running Running 6 seconds ago | ||
| ky2re9oz86r9 \_ redis.1 redis:7.4.0 manager1 Shutdown Shutdown 8 seconds ago |
There was a problem hiding this comment.
I guess for this one, we'd then have to change to 7.3 -> 7.4 🤔
- What I did
Updated redis example tags from 3.0.x to latest patch n and n-1 versions.
3.0.5 and 3.0.6 use image format v1 and they're all just old anyway.
- How I did it
fd -e md -X sed -i 's,3\.0\.5,7.4.0,g'fd -e md -X sed -i 's,3\.0\.[67],7.4.1,g'- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)